1
Vote

REPL window has IntellisenseController.DisconnectSubjectBuffer called without having a buffer parser set

description

I saw an assertion when closing VS, not having used the repl window at all in that session (though there may have been one open).

VS crashed before I could grab the stack trace, but the call to DisconnectSubjectBuffer comes from VS when the text view is closed. The assertion was because _bufferParser was null.

Looking at the rest of this function, I'm not entirely sure what purpose the assertion serves, since we get the "correct" parser from the parameter (buffer) and then use the instance variable.

Because of the assertion (and the VS crash), I don't know whether we would have hit a null reference exception in a release build.

comments