1

Resolved

FileNode.cs incorrect FireItemRenamed arguments.

description

I noticed this while trying to work with the rename event.

Namely, the signature of function being called:
        public void FireItemRenamed(HierarchyNode node, string oldName) {
            this.Fire(node, (IVsExtensibility3 vsExtensibility, ProjectItem item) => {
                vsExtensibility.FireProjectItemsEvent_ItemRenamed(item, oldName);
            });
        }
however, the function being called with parameters:

this.ProjectMgr.ExtensibilityEventsDispatcher.FireItemRenamed(this, Path.GetFileName(newFileName));

I'd also advise to actually pass the oldFilename without using Path.GetFileName.

comments

Zooba wrote May 1 at 5:39 PM

Thanks, we should be able to get this fixed up for 2.1.